I need correct currency rounding on the client side

wolfganguhr

Hello

On the server side the correct currency rounding actually wors:

        /// <summary>
        /// CurrencyInfo supports two currencies and the conversion rules incluing the
        /// rouding based on
        /// </summary>
        [Test]
        public void Test_05_TCurrencyInfo_2()
        {
            TCurrencyInfo getCurrencyInfo = new TCurrencyInfo("EUR", "JPY");

        Assert.AreEqual(1.23m, getCurrencyInfo.RoundBaseCurrencyValue(1.23456m), "Round to 2 digits");
        Assert.AreEqual(1.0m, getCurrencyInfo.RoundForeignCurrencyValue(1.23456m), "Round to 0 digits");

        decimal exchangeRate = 1 / 119.7295m;

        Assert.AreEqual(0.84m, getCurrencyInfo.ToBaseValue(100.00m, exchangeRate),
            "Conversion from 100 YEN to 0.83 EUR");
        Assert.AreEqual(11973, getCurrencyInfo.ToForeignValue(100.00m, exchangeRate),
            "Conversion from 100 EUR to 11983 YEN");
        Assert.AreEqual(120, getCurrencyInfo.ToForeignValue(1.00m, exchangeRate),
            "Conversion from 1 EUR to 120 YEN");

        getCurrencyInfo.ForeignCurrencyCode = "GBP";     // Change foreign Currency to Pound ...
        exchangeRate = 1 / 0.8801m;

        Assert.AreEqual(113.62m, getCurrencyInfo.ToBaseValue(100.00m, exchangeRate),
            "Conversion from 100 GBP to 113.62 EUR");
        Assert.AreEqual(88.01m, getCurrencyInfo.ToForeignValue(100.00m, exchangeRate),
            "Conversion from 100 EUR to 88.01 GBP");
    }

In this case TCurrencyInfo reads the complete a_currency table and interpretes the a_display_format_c column. In order to do a correct reporting I need the same routine on the client side.

Any ideas?
Best regards
Wolfgang

christiankatict

Hi Wolfgang,

the TCurrencyInfo would need to request the Cacheable DataTable 'CurrencyCodeList' instead of directly accessing the DB Table a_currency.
Getting a DataTable from the Cache Manager works the same on server and client side, and will also speed up the instantiation of TCurrencyInfo Objects if it is instantiated multiple times as the DB table will be read only the first time into the Cache, if it isn't already in into the Cache by an earlier Cache request for 'CurrencyCodeList' (by any user!).

TCurrencyInfo obviously also would need to be defined in a Shared DLL as it will need to be called from both server and client side.

Kind regards,

ChristianK

pokorra

For the reports, the rounding is already done by our rendering engine.
Therefore this does not have high priority to round values on the client side.