Using FMainDS

joejoe2010

Hi,

I would like to use FMainDS / MainDS in ParterMain.ManualCode.cs but I'm not sure how to do it.
Any hints would be appreciated.

Please see bazaar.launchpad.net/_jomammele/ ... ision/1625

Thank you
Joachim

pokorra

Hello Joachim,

regarding PartnerMain.ManualCode.cs: this is the old menu system, which looks like the old Petra 2.x, but we will probably not use in OpenPetra.
It has too many menus. So it is not worth changing that file.

What I meant in the bug notes
sourceforge.net/apps/mantisbt/o ... php?id=681
was the UINavigation yml file, which is the central file for all menu items in OpenPetra:
bazaar.launchpad.net/_openpetrac ... gation.yml

Hope that helps,
Timotheus

joejoe2010

Hi Timo,

thank you for your post. I hope you had a good vacation time.

Well, I didn't know that PartnerMain.ManualCode.cs isn't used at the moment. Don't you think it might be good to move all unused source code to an extra branch and remove them from trunk? This would help to avoid confusion.
(The other day I've also been trying to edit another source code file and later on I noticed with the Visual Studio GUI-Viewer that this file/GUI seemed to be unused because I had never seen this window on the current OpenPetra. :-( )

Regarding to your comment in mantis: I already modified UINavigation.xml in commit 1623.
But thanks anyways.

So if not in PartnerMain.ManualCode.cs then where do I need to add the code to enable that the last accessed family key is displayed in the NewPartner-Window?

Thanks and Greetings
Joachim

pokorra

Thanks Joachim, the time in the village where I grew up was not much relaxing but good.

Regarding the old code for the menu driven navigation screens: I have filed an issue now sourceforge.net/apps/mantisbt/o ... php?id=720, and will wait for other members of the team to comment on it.

Ah, I now realize, that TFrmPartnerMain.NewPartner is defined in the file bazaar.launchpad.net/_openpetrac ... ualCode.cs, as a static function, so we will need to keep that file still.

But the MainDS is only kept for each screen, so you won't be able to reuse that.

So the better solution is: For the last family key: you can use the p_recent_partners table to get the last partner of the current user.
openpetraorg.sourceforge.net/dbd ... up=partner
You will need to check for the partner class, because it contains PERSON etc as well.
Search the code (full text search with Notepad++ or similar) for PRecentPartners, to see if there are already functions that can be useful to you.

So you are right, the best place to pass the last partner key is in file PartnerMain.ManualCode.cs, you should modify the method NewPerson to check for the recent FAMILY partner and pass that with frm.SetParameters.

All the best,
Timotheus