386_on_changing_a_user_password_it_should_be_entered_twice

joejoe2010

Hi,

I was trying to solve bug 386. I was planning to edit bazaar.launchpad.net/_openpetrac ... ualCode.cs so that the user is asked to enter his new password twice.
But then I noticed that this is already implemented. The respective code can be found in:
bazaar.launchpad.net/_openpetrac ... ManMain.cs

So my question is: why are there 2 code files implementing the password change functionality?

Greetings
Joachim

pokorra

Hello Joachim,

bazaar.launchpad.net/_openpetrac ... ManMain.cs
is called when the user changes his own password, in the settings. To avoid mistakes, the user has to enter the old password, and enter the new password twice.

bazaar.launchpad.net/_openpetrac ... ualCode.cs
is for the system administrator, who can assign a new password. He does not need to know the old password of the user, and should be able to change the password anyway.
He will usually use a generated password anyway, copy&paste from randpass.com/ etc, so I did not bother to have to enter the password twice.

I should have entered this as a comment to the bug report a long time ago. Sorry.

joejoe2010

Hey,

now I understand. ;-)

I think it would be good to comment this now - and to remove the TODO-tag on line 93 of bazaar.launchpad.net/_openpetrac ... ManMain.cs.

I could do this but then I would have to create a new branch just for commenting.

Greetings
Joachim

pokorra

I have fixed this in trunk now.

For small things like this, you can create a branch, with a date in the name, and fix several things, and propose for a merge after a week, and then create a new branch.
For bigger issues, you should still create one branch per issue.