Adding NOT NULL to existing fields in petra.xml

pokorra

Hello,

I noticed that pm_short_term_application.pm_st_leadership_rating_c is now NOT NULL.
Wolfgang, did you change that?
Please advise which value to use in upgrades.

I checked the Petra 2.3 database for the table pt_leadership_rating:
NULL No information 0 \N 0 \N \N \N \N \N
0 No clear L'drshp info about this person 0 \N 0 \N \N \N \N \N
1 No clear L'drshp potential, not a leader 0 \N 0 \N \N \N \N \N
2 Assist. up to 25 or Fellowship leader 0 \N 0 \N \N \N \N \N
3 Leader of 6-10 - Definite potential 0 \N 0 \N \N \N \N \N
4 Leader of 25 - Assured potential 0 \N 0 \N \N \N \N \N
5 Leader of 100+ - Seasoned veteran 0 \N 0 \N \N \N \N \N

Thanks,
Timotheus

pokorra

I will resolve this situation like this:

I am adding the pt_leadership_rating table to the base database, and will replace the NULL in the primary key with "-1".
Then I will add "-1" as the default value in petra.xml for pm_short_term_application.pm_st_leadership_rating_c.

see my commit at bazaar.launchpad.net/_tpokorra/o ... ision/1748

Generally, if we change a field from NULL to NOT NULL, it would be good to add a default value in petra.xml.

wbrowa

I don't know who added the NOT NULL attribute to that field. In my current branch I recently removed the NOT NULL attribute as I ran into problems with saving application records. Actually this field will soon be completely removed from that table as it is not needed any more. So it looks like we can then probably also completely drop table pt_leadership_rating. My aim is to work on removing those fields and tables that are not needed any longer within in the next two weeks.

pokorra

Thanks Wolfgang, that is even better!