Question about NUNIT-Testing

joejoe2010

Hi everybody,

I've been studying a bit about NUNI-Testing and I have a question,

The question relates to bazaar.launchpad.net/_openpetrac ... nerEdit.cs

I understand that messages are only displayed if an assertion fails like in fe.
Assert.AreEqual(1, testPartnerLocations.Rows.Count, "the partner should only have one location");

But by this, messages that announce that something went well, aren't displayed.
Am I right that the following lines announce that something went well?
Assert.AreEqual(TSubmitChangesResult.scrOK, result, "TPartnerEditUIConnector SubmitChanges return value");
Assert.Greater(MainDS.PPartnerLocation[0].LocationKey, 0, "TPartnerEditUIConnector SubmitChanges returns valid location key");
But the mesages would only appear in the log if the asserts went wrong.

What do you think?

I also noticed that in ci-win.solidcharity.com/job/Open ... onsoleFull there appear several database-errors:
[nunit2] 04:13:53 Error executing non-query SQL statement.
[nunit2] The SQL Statement was:
[nunit2] INSERT INTO a_gift(a_ledger_number_i, a_batch_number_i, a_gift_transaction_number_i) VALUES(43, 99999999, 1)
[nunit2] Possible cause: Npgsql.NpgsqlException:
[nunit2] insert or update on table "a_gift" violates foreign key constraint "a_gift_fk1"
[nunit2] Severity: ERROR
[nunit2] Code: 23503

But although the respective tests don't fail:
[nunit2] Tests run: 3, Failures: 0, Not run: 0, Time: 1.187 seconds

Should we implement some asserts that check for DB-errors?

Greetings
Joachim

pokorra

the purpose of the message in the assert call is for me, to show which assert failed.
otherwise I would just get a message in NUnit console: expected value, but was different value. but with the message, I can understand which line failed.

If something went well, nothing is displayed, which should be the normal case.
I could have used different words for the message, to avoid confusion.

The SQL error that you spotted is a good example: that tests is actually a test for the database, and it checks if the database complains.
this is the test:
bazaar.launchpad.net/_openpetrac ... DB/test.cs
the line is:
Assert.Throws(Is.InstanceOf(typeof(Exception)), new TestDelegate(WrongOrderSqlStatements));

I have these links as comments with that test:
see nunit.net/blogs/?p=63, we expect an exception to be thrown
also nunit.org/index.php?p=exceptionAsserts&r=2.5

So we are testing the database, and expect an exception to be thrown. If that happens, the test is successful.

pokorra

I will reply to your email here, so that others can read as well:

I think it would be helpful for me to get a bit more detailed instructions about what to do with the NUNIT-test. For which cases should test being implemented? For bugs dicovered by Rob? For anything that a user might intent to do on the GUI?...
I've already studied some of the theory of NUNIT-tests so more the less I now know what it's about.

Timo asked me to first study the PartnerEdit-Tests and extend them - but as I had some questions and found a bug I couldn't proceed a lot on that.

Is there a list about fe. the methods and attributes of a Partner. fe. TPartnerEditUIConnector and PPartnerAccess.LoadViaPLocation
Or would I need to go into the source code and search for the names of the respective methods and attributes. (As I didn't write the code I don't know the names of the methods and attributes)

I guess it is helpful that you understand the data structure of partner, family, person, partner location, etc.
The Access classes with LoadVia... are all generated, using the foreign keys of the tables.
Perhaps Christian or myself should give you an introduction on Skype into the partner edit system?
you can see the code that I used to create sample partners, in the partneredit test file.
bazaar.launchpad.net/_openpetrac ... nerEdit.cs
CreateFamilyWithPersonRecords and CreateNewLocation. that shows already some connections between the tables.

the other option would be to work on the Finance screens, GL, etc.
but finance is even more complex than partners.
bazaar.launchpad.net/_openpetrac ... rm/test.cs
that test uses NUnitForms to open the screen (without you seeing it), and testing what the user could click and would expect.
perhaps that would allow you to run tests for bugs that have recently been reported.

pokorra

Is there a list about fe. the methods and attributes of a Partner. fe. TPartnerEditUIConnector and PPartnerAccess.LoadViaPLocation
Or would I need to go into the source code and search for the names of the respective methods and attributes. (As I didn't write the code I don't know the names of the methods and attributes)

I forgot to mention our "javadoc" style documentation, which is updated every night on Jenkins: codedoc.openpetra.org

For a direct link to the Partner Edit UIConnector, see this link: ci.openpetra.org/job/OpenPetraCo ... 02513.html