Question about columns in Grid of Partner-Edit Subscription

joejoe2010

Hi,

I've got a question about the columns a Grid shows.
My question relates to the Partner-Edit Subscription Tab.

In E:\openpetra\bzr\work-784 PartnerEdit Bank Tab\csharp\ICT\Petra\Client\MPartner\Gui\UC_FinanceDetails.yaml I can see

    grdDetails:
        Dock: Fill
        Columns: [PFinanceDetail.PublicationCode, PFinanceDetail.SubscriptionStatus, PFinanceDetail.GratisSubscription]

So there should only be displayed 3 columns.
But on the Tab I can see many more.

Where do they come from?

Thank you
Joachim

pokorra

we are talking about this new file, from your branch:
bazaar.launchpad.net/_jomammele/ ... tails.yaml

What additional columns are displayed?

I can have a look at your branch later tonight.

joejoe2010

Hi,

I found this article.https://sourceforge.net/apps/mediawiki/openpetraorg/index.php?title=How-To:_Creating_a_Maintain_Table_screen#DetailTable_Element
This helped me to understand more the process of creating a new screen and probably solved the question about the columns in the Grid.

Btw: I renamed FinanceDetail to BankingDetail -> bazaar.launchpad.net/_jomammele/ ... etail.yaml

Greetings
Joachim

joejoe2010

Hi,

I could manage to get the generated.cs files created.
But on trying to compile them there appears an error

Do you know where it results from?

You can find the log here: ci.openpetra.org/job/OpenPetraBu ... 46/console

Greetings
Joachim

pokorra

Hello Joachim,

I have committed a fix to trunk, so that the winforms generator creates valid code for this situation, and shows a warning that something is unexpected.

The problem is with the txt controls, that link to a database field of type string, but you define Format=Integer.
For txtAccountName, it should be a string, I think.

For the other fields, that can be different for each country. For the moment, please remove the Format=Integer from all these fields.
In the far future, we might need to offer plugins for each country that check for the validity of a IBAN number, etc. But not now. We need quick results.

All the best,
Timotheus

joejoe2010

Hi Timo,

thank you for the hint.
I removed the integer-tags and made a merge from trunk.

Unfortunally the error persist.

Where can I see TLogging writes while compiling?

Btw: How can I configure Jenkins to build automatically once I make a commit on launchpad?

Thank you,
Joachim

pokorra

Hello Joachim,

this is now a different error, in file UC_BankingDetails-generated.cs

@[deleted]: there is a bug in controlMaintainTable.cs, function ValidateAllData, line 618:

{#IFDEF SHOWDETAILS}
        if (FPreviouslySelectedDetailRow != null)
        {
{#ENDIF SHOWDETAILS}

but the else in line 695 is always added. I don't know which behaviour is intended.

@[deleted]: it seems you have no details defined, but they are all in another subcontrol.
I would advise you follow an example like UC_IndividualData_Abilities.yaml, which is very similar, and defines the detail controls directly in the one yaml file.
Or are you following another example? Perhaps that uses a different template?

Where can I see TLogging writes while compiling?

it is on the console, if you use nant from a command prompt. Or it is in the Developer's assistant detailed output page, I think.
You can also run just

C:\Users\tpokorra\Documents\openpetra\joachim>nant generateWinform -D:file=C:\Users\tpokorra\Documents\openpetra\joachim\csharp\ICT\Petra\Client\MPartner\Gui\UC_BankingDetails.yaml

That is how I use it, it shows me just the logging and errors of that one file.

Btw: How can I configure Jenkins to build automatically once I make a commit on launchpad?

on ci.openpetra.org/job/OpenPetraBu ... /configure, go to Build Triggers; the current setting is: Poll SCM, Schedule 35 * * * *
The syntax for the schedule is similar to cron jobs (linuxmoz.com/crontab-syntax-tutorial/).
So the current setting means: check every hour, at the 35th minute, if there has been a new commit to bazaar, and then build if there is a new commit.

All the best,
Timotheus

joejoe2010

Hi Timo,

thank you for your post.

I've now moved all yaml-code into one yaml-file.
Christian had advised me to use UC_Subscription and UC_Subscriptions as example - that's why I had 2 yaml-files.
The template was the same anyway.

But now I get an error like:
generateWinform:
[ExecDotNet] parsing E:\openpetra\bzr\work-784 PartnerEdit Bank Tab/
db/petra.xml
[ExecDotNet] Loading E:\openpetra\bzr\work-784 PartnerEdit Bank Tab\
csharp\ICT\Petra\Client\MPartner\Gui\UC_BankingDetails.yaml...
[ExecDotNet] Writing UC_BankingDetails-generated.Designer.cs
[ExecDotNet] Writing UC_BankingDetails-generated.cs
Compiling E:\openpetra\bzr\work-784 PartnerEdit Bank Tab\delivery\projects/sharp
develop4/Ict.Petra.Client.MPartner.Gui.csproj
e:\openpetra\bzr\work-784 PartnerEdit Bank Tab\csharp\ICT\Petra\Client\MPartner\
Gui\UC_PartnerEdit_PartnerTabSet-generated.cs(75,43) : error CS0234: Der Typ- od
er Namespacename "TUC_PartnerBankingDetails" ist im Namespace "Ict.Petra.Client.
MPartner.Gui" nicht vorhanden. (Fehlt ein Assemblyverweis?)
Namesace not contained in ...

TUC_PartnerBankingDetails is mentioned in various files in the MPartner/GUI folder. But where should it get defined?

I'm still in doubt if the tab and the related classes, methods etc should be called "FinanceDetails" or "BankingDetails".
I was first using FincanceDetails - but then I saw that the relating table in the DB is called BankingDetails and I changed it.
But now I'm a but confused because there are already ocurrencies of FinanceDetails fe. in PartnerEdit.yaml (mniMaintainFinanceDetails).
Which one should I use?

About TLogging: I was searching for a extra log-file. Thank you.

About Jenkins: 35 * * * *
How often do you check in your Jenkin-Jobs for commits?
Would it be possible to check fe. every 5 minutes?

Thank you in advance
Joachim

pokorra

ok, UC_Subscription could be a good example as well. I have no idea why it works there, but not with your other example.
But if you have it in one yaml file, that should be fine as well, since you don't need the details to be used anywhere else, so no need for another user control.

for your other error:
you need to change UC_PartnerEdit_PartnerTabSet.yaml, line 64, TUC_PartnerBankingDetails to TUC_BankingDetails, because it is called TUC_BankingDetails in UC_BankingDetails-generated.cs

Bankingdetails is a subset of FinanceDetails. Financedetails also includes the frequency of receipt letters (p_partner.p_receipt_letter_frequency_c). You should see that on the screenshot I sent you some weeks ago.
For the moment, you can ignore those things.

Tlogging: there used to be a log file written for the winforms generator, but I cannot find it, and I think it is not necessary.

Jenkins: I am happy for you to change it to */5 * * * *
I think this is the correct syntax, according to Google search results.

All the best,
Timotheus

joejoe2010

Hi Timo,

thank you for your answer. I applied the changes you suggested. (as I wrote you in IRC).

I suppose that the many errors that I got afterwards appeared because I compiled the client without generating the generated.cs-files from the changed yaml-file.

After executing generateWinform another error appears:

     [ExecDotNet] working on /var/tmp/OpenPetraBuildJoachim/csharp/ICT/Petra/Client/MPartner/Gui/UC_FinanceDetails.yaml
        [ExecDotNet] Loading /var/tmp/OpenPetraBuildJoachim/csharp/ICT/Petra/Client/MPartner/Gui/UC_FinanceDetails.yaml...
        [ExecDotNet] Problem while processing -op:generate -ymldir:/var/tmp/OpenPetraBuildJoachim/csharp/ICT/Petra/Client -TemplateDir:/var/tmp/OpenPetraBuildJoachim/inc/template/src/Winforms -ResourceDir:/var/tmp/OpenPetraBuildJoachim/resources -petraxml:/var/tmp/OpenPetraBuildJoachim/db/petra.xml -localisation: -Server.DebugLevel:0 
        [ExecDotNet] System.NullReferenceException: Object reference not set to an instance of an object
        [ExecDotNet]   at Ict.Tools.CodeGeneration.Winforms.TWinFormsWriter.CreateCode (Ict.Tools.CodeGeneration.TCodeStorage ACodeStorage, System.String AXAMLFilename, System.String ATemplateFile) [0x00000] in <filename unknown>:0 
        [ExecDotNet]   at Ict.Tools.CodeGeneration.TProcessYAMLForms.ProcessDocument () [0x00000] in <filename unknown>:0 
        [ExecDotNet]   at Ict.Tools.GenerateWinForms.Program.ProcessFile (System.String filename, System.String ASelectedLocalisation) [0x00000] in <filename unknown>:0 
        [ExecDotNet]   at Ict.Tools.GenerateWinForms.Program.Main (System.String[] args) [0x00000] in <filename unknown>:0

Do you have an idea where this comes from?

Thank you,
Joachim

pokorra

Hello Joachim,

I have looked at this problem.
The reason is your line "DetailTable: PFinanceDetails" in UC_FinanceDetails.yaml. That table does not exist, you need to use table PBankingDetails.

I have fixed the generator in trunk, so that it shows a proper exception in the case that an invalid table name is used.

All the best,
Timotheus

joejoe2010

Hi Timo,

thank you.
What a shame. I had "PBankingDetails" beforehand already defined as DBTable. But as I changed everything from BankingDetails to FinanceDetails I probably changed too much.

I'm still getting errors, probably because I still need to adapt the example-Manualcode.cs file I took to FinanceDetails...

Gretings
Joachim

pokorra

Hello Joachim,
please merge from my branch lp:_{tpokorra/openpetraorg/dev_0000784_partner_edit_finance_details_still_missing}

adding new records and saving works now.
selection of a bank via partner key at the moment, in future somehow this should/could be transparent to the user, by bank sort code / BLZ / BIC.

loading of bankingdetails from the server does not work yet.

Hopefully that gives you a good step forward...

good night,
Timotheus