In my testing today I found a bug in the new delete code logic which I thought I would confess to. It would have been nice if I had discovered it before committing to trunk, but I feel slightly happier that I found it before one of you! Basically it happens on any screen that is backed by a data table that has a column that is a deletable_flag. (many of the Partner and Personnel setup screens are like this.)

Click on a row - delete button is disabled correctly
Ctrl+Click on a second row - delete button is now enabled because there are two rows highlighted
Ctrl+Click on the first row - now only one row is highlighted but the delete button stays enabled because 'un-highlighting' a row does not produce any events
You can now click delete and the row will be deleted!

I will file a bug and think about the best way of resolving it, but I wanted to let you know.

Alan

18 days later

Good news. I have fixed this bug in my recent commit to my local branch. It should be in trunk on 10 July 2013.

As I investigated it also became apparent that there was a similar bug when using SHIFT+up/down. So that is also fixed (different fix).