.net web services on Jenkins

pokorra

Hello Christian, and Alan,

I am starting a new thread, to keep the discussion manageable...

In the past days, I have continued to work on my branch:
code.launchpad.net/_tpokorra/op ... ressdialog

I have tried to clean up the Session handling, so that it works fine on Linux and on Windows.

This has improved the situation on my Windows development server, for nant test.
The problem is that it still gives trouble in the NUnit tests on Jenkins:
ci-win.openpetra.org/view/All/j ... otingTest/

I wonder what could be the difference.
I know that for my own TinyWebServer, I needed some permissions to run a server on a given port.
But with Alans Server, should it just work?
Can we get some logging, if the server was able to start?

I just checked ci-win.openpetra.org/view/All/j ... st/ws/log/ and cannot see recent entries in the TestServer.log.
I wonder if the tests run against another server, that is still running, and has code from another build directory.
Though I did include stopServer in the list of tasks to be executed before the test.

In my own TinyWebserver, I implemented a parameter that would optionally stop the server after 2 hours, so that on Jenkins we don't have a stray web server.

I have now started another test run on a different port.

We will see if that gets us further.

Timo

pokorra

ok, it seems the problem is about the port of the server.
The Unit Tests starts the server itself, and does not use the port from the jenkins job, but from the config file.
I will have to look more into this.

pokorra

I finally remembered that for the other jobs, I am already using the nant task enable-sqlite-config-for-jenkins for example for job ci-win.openpetra.org/job/Openpe ... WinSQLite/ which allows to set the Server.Port as well, reliably.
That way a local OpenPetra.build.config is created with the Server.Port and Database connection data. This will be used even when the server is started from within the NUnit test.

Lets see if that gets us further on the remoting tests...

pokorra

Ok, now the same port (4321) is used for all start and stop of server.
But still, the NUnit tests fail (Ict.Testing.lib.ClientServerRemoting.dll)
ci-win.openpetra.org/view/All/j ... 12/console

Christian: can you please test if the test passes now better on your Windows Development machine, after my clean up on my branch?

Thanks,
Timo

christiankatict

Hi Timo,

Thanks for your investigations and your work on this!

I have merged your branch into my branch this morning and now one NUnit Test fails when I run nant test on my development PC:

1) SetUp Error : Tests.MFinance.GLBatches.TGLBatchesTest.TestCreateBatchAndPost
SetUp : System.Exception : invalid response from the server
at Ict.Common.Remoting.Client.THttpConnector.CallWebConnector(String AModuleName, String methodname, SortedList`2 parameters, String expectedReturnType) in c:\openpetra_branches\20140211_replace_net_remoting\trunk\csharp\ICT\Common\Remoting\Client\HTTPConnector.cs:line 158
at Ict.Petra.Client.App.Core.RemoteObjects.TMSysManNamespace.TSysManMaintenanceNamespace.TSysManMaintenanceUserDefaultsNamespace.TSysManMaintenanceUserDefaultsWebConnectorsNamespace.GetUserDefaults(String AUserName, SUserDefaultsTable& AUserDefaultsDataTable) in c:\openpetra_branches\20140211_replace_net_remoting\trunk\csharp\ICT\Petra\Client\app\Core\Remoteobjects\ClientGlue.MSysMan-generated.cs:line 345
at Ict.Petra.Client.App.Core.TUserDefaults.InitUserDefaults() in c:\openpetra_branches\20140211_replace_net_remoting\trunk\csharp\ICT\Petra\Client\app\Core\UserDefaults.cs:line 353
at Ict.Testing.NUnitPetraClient.TPetraConnector.Connect(String AUserName, String APassword, Int64 ASiteKey) in c:\openpetra_branches\20140211_replace_net_remoting\trunk\csharp\ICT\Testing\lib\NUnitPetraClient\connectPetra.cs:line 140
at Ict.Testing.NUnitPetraClient.TPetraConnector.Connect(String AConfigName, Boolean AThrowExceptionOnLoginFailure) in c:\openpetra_branches\20140211_replace_net_remoting\trunk\csharp\ICT\Testing\lib\NUnitPetraClient\connectPetra.cs:line 86
at Tests.MFinance.GLBatches.TGLBatchesTest.Setup() in c:\openpetra_branches\20140211_replace_net_remoting\trunk\csharp\ICT\Testing\lib\MFinance\GLForm\test.cs:line 56
at NUnit.Extensions.Forms.NUnitFormTest.init()

However, I have found out that if I make one specific NUnit Test that is failing for you ('TestKeepAliveWithoutTimeout') and that was previously also failing for me 'inactive' so that it doesn't get executed then all the rest of the NUnit tests run! :-) Hopefully this is a pointer for you dig deeper on those issues...

Note: I have now run the Main Menu tests for the first time in this Branch and I get the following NUnit Test errors:

1) Test Failure : Tests.MainNavigationScreens.TMainNavigationTest.TestBrokenClientPermissions
Expected the fail reason to be module access permission
Expected: True
But was: False

at Tests.MainNavigationScreens.TMainNavigationTest.TestBrokenClientPermissions() in c:\openpetra_branches\20140211_replace_net_remoting\trunk\csharp\ICT\Testing\lib\MainNavigationScreens\test.cs:line 466

2) SetUp Failure : Tests.MainNavigationScreens.TMainNavigationTest.TestLoopThroughUINavigation
SetUp : Failed to connect to the Petra Server. Have you forgotten to launch the Server Console
at Tests.MainNavigationScreens.TMainNavigationTest.Setup() in c:\openpetra_branches\20140211_replace_net_remoting\trunk\csharp\ICT\Testing\lib\MainNavigationScreens\test.cs:line 80
at NUnit.Extensions.Forms.NUnitFormTest.init()

3) SetUp Failure : Tests.MainNavigationScreens.TMainNavigationTest.TestOpenAllWindows_de_AT
SetUp : Failed to connect to the Petra Server. Have you forgotten to launch the Server Console
at Tests.MainNavigationScreens.TMainNavigationTest.Setup() in c:\openpetra_branches\20140211_replace_net_remoting\trunk\csharp\ICT\Testing\lib\MainNavigationScreens\test.cs:line 80
at NUnit.Extensions.Forms.NUnitFormTest.init()

4) SetUp Failure : Tests.MainNavigationScreens.TMainNavigationTest.TestOpenAllWindows_de_CH
SetUp : Failed to connect to the Petra Server. Have you forgotten to launch the Server Console
at Tests.MainNavigationScreens.TMainNavigationTest.Setup() in c:\openpetra_branches\20140211_replace_net_remoting\trunk\csharp\ICT\Testing\lib\MainNavigationScreens\test.cs:line 80
at NUnit.Extensions.Forms.NUnitFormTest.init()

5) SetUp Failure : Tests.MainNavigationScreens.TMainNavigationTest.TestOpenAllWindows_de_DE
SetUp : Failed to connect to the Petra Server. Have you forgotten to launch the Server Console
at Tests.MainNavigationScreens.TMainNavigationTest.Setup() in c:\openpetra_branches\20140211_replace_net_remoting\trunk\csharp\ICT\Testing\lib\MainNavigationScreens\test.cs:line 80
at NUnit.Extensions.Forms.NUnitFormTest.init()

6) SetUp Failure : Tests.MainNavigationScreens.TMainNavigationTest.TestOpenAllWindows_en_GB
SetUp : Failed to connect to the Petra Server. Have you forgotten to launch the Server Console
at Tests.MainNavigationScreens.TMainNavigationTest.Setup() in c:\openpetra_branches\20140211_replace_net_remoting\trunk\csharp\ICT\Testing\lib\MainNavigationScreens\test.cs:line 80
at NUnit.Extensions.Forms.NUnitFormTest.init()

7) SetUp Failure : Tests.MainNavigationScreens.TMainNavigationTest.TestOpenAllWindows_en_US
SetUp : Failed to connect to the Petra Server. Have you forgotten to launch the Server Console
at Tests.MainNavigationScreens.TMainNavigationTest.Setup() in c:\openpetra_branches\20140211_replace_net_remoting\trunk\csharp\ICT\Testing\lib\MainNavigationScreens\test.cs:line 80
at NUnit.Extensions.Forms.NUnitFormTest.init()

8) SetUp Failure : Tests.MainNavigationScreens.TMainNavigationTest.TestOpenAllWindows_fr_FR
SetUp : Failed to connect to the Petra Server. Have you forgotten to launch the Server Console
at Tests.MainNavigationScreens.TMainNavigationTest.Setup() in c:\openpetra_branches\20140211_replace_net_remoting\trunk\csharp\ICT\Testing\lib\MainNavigationScreens\test.cs:line 80
at NUnit.Extensions.Forms.NUnitFormTest.init()

9) SetUp Failure : Tests.MainNavigationScreens.TMainNavigationTest.TestPermissionsSystemManager
SetUp : Failed to connect to the Petra Server. Have you forgotten to launch the Server Console
at Tests.MainNavigationScreens.TMainNavigationTest.Setup() in c:\openpetra_branches\20140211_replace_net_remoting\trunk\csharp\ICT\Testing\lib\MainNavigationScreens\test.cs:line 80
at NUnit.Extensions.Forms.NUnitFormTest.init()

Kind regards,

ChristianK

pokorra

Please let us first focus on this dll: Ict.Testing.lib.ClientServerRemoting.dll
I know that there are more problems, but I want to get that fixed first.

Your comment in your branch is misleading for test TestKeepAliveWithoutTimeout:
bazaar.launchpad.net/_christian- ... ision/2424
Ignore("We know that this doesn't work yet! (According to Timo)")
I actually would say this test should work. We should fix it. The client disconnects, and the server should remove the client from the list.
The test TestKeepAliveWithoutTimeout sometimes even works on my Windows workstation, but I also have seen it failing there.
We need to stabilize that test.

But my bigger problem is: why do we get different behaviour on Jenkins compared to running the tests in Ict.Testing.lib.ClientServerRemoting.dll locally on our Windows workstations?
ci-win.openpetra.org/view/All/j ... 12/console

christiankatict

Hi Timo,

Sorry about the misleading comment - I just copy-and-pasted it from Method 'TestKeepAliveWithTimeout'.

Prompted by your previous post I experimented a bit with Method 'TestKeepAliveWithoutTimeout' and got it to consistently work when I run it from within SharpDevelop by changing the Thread.Sleep value in Method 'StartOpenPetraServer' from 5.0 to 15.0. If I keep that value somewhere between 6.0 and 15.0 I get varying test failures, incl.

there should not be any clients connected at the moment
Expected: String containing "* no connected Clients *"
But was: <string.Empty>

and

Invalid server response.

but never get that test to pass!

So this points to a timing issue, which would also explain why that test sometimes works and sometime doesn't work on your local machine.

Just a few observations...

Kind regards,

ChristianK

pokorra

Hello Christian:
regarding the timing: we need to calculate the various timeouts, so that we understand the amount of time that is needed.
Then we could also modify those timeouts for the Unit tests, so that the test only needs the minimum amount of time and still succeeds.

The bigger problem: I have the suspicion that the Webserver does not even start on my Jenkins job on Windows.
Please see the log files: ci-win.openpetra.org/view/All/j ... st/ws/log/
nothing in TestServer.log at all.

Can you please run my test on Jenkins, and check the task manager if Ict.Tools.OpenPetraWebServer.exe is started at all?

I am now working on the webserver to do some logging to a log file, for start up errors, eg. port already in use, etc

Timo

christiankatict

Hi Timo,

I have run your Job 'TimotheusRemoting' on Windows Jenkins this morning and after it stops with the usual NUnit Test errors there are four Ict.Tools.OpenPetraWebServer.exe processes left 'hanging' where there was none before I startet the Job. So the Webserver runs when the NUnit Tests are run!

I have checked the logs on my local branch on my PC and there the log file \log\TestServer.log also only contains entries up to 19-Mar-2014. The log file that seems to get written to from the Webserver is called \log\WebServer.log on my machine, but that doesn't exist on Windows Jenkins (it doesn't exist either with my Job, 'OpenPetraBuildWinChristianTest_Without_Display'). Really strange...

Apart from that I do wonder whether we really need to start and stop the Webserver repeatedly for all those NUnit Tests. Would it not suffice if we had a call at the start of all tests that ensures that it is started (once)? We wouldn't even need a call at the end of all tests to ensure it gets stopped, as updating files while the Webserver is running shouldn't be an issue, right? That initial check could be done as part of the commands 'nant test', 'nant 'test-client', 'nant test-without-display', 'nant test-main-navigation-screens' and 'test-main-navigation-screens-core'. That should ensure that the Webserver is started when those tests are run from either OPDA or on the Windows Jenkins server (an issue might be separate Ports for separate Jenkins Jobs, though, to allow several Jobs to run concurrently!). Whenever developers would run or create individual NUnit tests they can ensure that the Webserver runs by themselves.
There might be specific NUnit Tests that would really need to start and stop the Webserver for specific purposes, but there shouldn't be many of those, I think.

Kind regards,

ChristianK

pokorra

Hello Christian,

it seems the main problem was that the Webserver was still running from my jobs working directory, and the exe was not overwritten with the newer version.

I have now extended Ict.Tools.OpenPetraWebServer this way:

we are now writing a log file to ci-win.openpetra.org/view/All/j ... og/view/
the server now has an option maxRuntimeInMinutes which means that the server will stop after 2 hours itself.

Now the server logs are written to:
ci-win.openpetra.org/view/All/j ... Server.log

Regarding your comment about starting and stopping the Webserver during the NUnit tests:
usually it is only started once.
but for the tests in Ict.Testing.lib.ClientServerRemoting.dll I need to start the server with a different timeout parameter, so that the test will not take minutes but only seconds.

There are still test failures, and I will look into those one by one.

But I am glad and thankful that the general problem is now solved, I think.

Timo

pokorra

Hello Christian,

it seems the main problem was that the Webserver was still running from my jobs working directory, and the exe was not overwritten with the newer version.

I have now extended Ict.Tools.OpenPetraWebServer this way:

we are now writing a log file to ci-win.openpetra.org/view/All/j ... og/view/
the server now has an option maxRuntimeInMinutes which means that the server will stop after 2 hours itself.

Now the server logs are written to:
ci-win.openpetra.org/view/All/j ... Server.log

There are still test failures, and I will look into those one by one.

But I am glad and thankful that the general problem is now solved, I think.

Timo

pokorra

ok, nant test-without-display now works on Windows Jenkins:
ci-win.openpetra.org/view/All/j ... d_console/?

I am now looking into the failure of Ict.Testing.lib.MFinance.GLForm.dll

pokorra

Hello Christian,
it seems that nant test now works completely. in Windows Jenkins, and locally as well.
I am not so sure, why it works now, since I have had problem with the GL Form dll at some point.

Please can you try my branch again?

Thanks,
Timo

christiankatict

Hi Timo,

I have merged your Branch into mine this morning, did a clean and generateSolution and ran 'nant test'.

The NUnit Tests now run successfully to completion - with 'TestKeepAliveWithoutTimeout' and 'TestKeepAliveWithTimeout' Ignored, plus several Tests in 'Tests.MFinance.GLBatches.GLAccountHierarchy_test' and 'Tests.MFinance.GLBatches.TGLBatchesTest' ignored. This is the same on my development PC and on Windows Jenkins, so that's very good news indeed!

Kind regards,

ChristianK