Nested functions with DB Transactions

pokorra

Christian,
I have a question.

Please have a look at U:\openpetraorg\csharp\ICT\Petra\Server\lib\MPartner\Extracts.cs

In the function CreateNewExtract you call DBAccess.GDBAccessObj.GetNewOrExistingTransaction with the out parameter NewTransaction, should you really commit the transaction on success, without checking for the value of NewTransaction?

I am working on a function that will import a list of partner keys from BestAddressTDSLocationTable, and I think I want to commit the whole transaction in the end, and it is confusing that the transaction will already be committed in CreateNewExtract.

Thanks for your comment,

Timo

pokorra

another thought: should the rollback also only happen where the transaction was created?
Otherwise it is possible that the transaction is rolled back several times?

christiankatict

Hi Timo,

well spotted, this should indeed happen as you described.

This has already been changed in Petra 2.3. I made two changes on 25 Aug 2009 which changed the implementation of CreateNewExtract to this end. This is not yet merged into OpenPetra since I didn't get round to merge Server code into OpenPetra as of now.
I suggest you take the Petra 2.3 implementation of CreateNewExtract over into OpenPetra since you need it already now.

Thanks.